-
Notifications
You must be signed in to change notification settings - Fork 4.4k
.Net - Agents KernelFunction Strategies #5895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t/semantic-kernel into feature_agent_framework
dotnet/samples/Concepts/AgentSyntax/Getting_Started/Step4_KernelFunctionStrategies.cs
Outdated
Show resolved
Hide resolved
dotnet/samples/Concepts/AgentSyntax/Getting_Started/Step4_KernelFunctionStrategies.cs
Outdated
Show resolved
Hide resolved
dotnet/samples/Concepts/AgentSyntax/Getting_Started/Step4_KernelFunctionStrategies.cs
Show resolved
Hide resolved
dotnet/samples/Concepts/AgentSyntax/Getting_Started/Step4_KernelFunctionStrategies.cs
Show resolved
Hide resolved
dotnet/samples/Concepts/AgentSyntax/Getting_Started/Step4_KernelFunctionStrategies.cs
Outdated
Show resolved
Hide resolved
dotnet/samples/Concepts/AgentSyntax/Getting_Started/Step5_JsonResult.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Agents/Core/Chat/KernelFunctionTerminationStrategy.cs
Outdated
Show resolved
Hide resolved
…semantic-kernel into feature_chat_strategy
dmytrostruk
reviewed
Apr 25, 2024
Member
dmytrostruk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's worth to update PR description as well, since FunctionResultProcessor class doesn't exist anymore.
dmytrostruk
approved these changes
Apr 25, 2024
SergeyMenshykh
approved these changes
Apr 26, 2024
markwallace-microsoft
approved these changes
Apr 26, 2024
LudoCorporateShark
pushed a commit
to LudoCorporateShark/semantic-kernel
that referenced
this pull request
Aug 25, 2024
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Users of `AgentGroupChat` will likely require strategies that rely on AI processing. Text processing alone is insufficient, but developers need other options than calling an AI model. With this update, our strategy story supports either. ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> Introducing support `SelectionStrategy` and `TerminationStrategy` that utilize LLM processing with support for result processing. - `KernelFunctionSelectionStrategy` - `KernelFunctionTerminationStrategy` ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
agents
experimental
Associated with an experimental feature
feature branch
PR targeting a feature branch
.NET
Issue or Pull requests regarding .NET code
PR: ready for review
All feedback addressed, ready for reviews
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Users of
AgentGroupChatwill likely require strategies that rely on AI processing. Text processing alone is insufficient, but developers need other options than calling an AI model. With this update, our strategy story supports either.Description
Introducing support
SelectionStrategyandTerminationStrategythat utilize LLM processing with support for result processing.KernelFunctionSelectionStrategyKernelFunctionTerminationStrategyContribution Checklist